accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo issue #254: [ACCUMULO-4506] Add a timeout to the replication task
Date Mon, 01 May 2017 14:51:23 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/254
  
    > I've been reading up on Executors#sameThreadExecutor, and I don't think we can use
this here since it runs the task prior to getting any Future. The timeout logic would not
kick in until the task is finished.
    The task has to be run in a separate thread while the main thread idles to trigger the
timeout.
    
    Ahh, bummer. Thought I could be tricky and help save us yet another thread ;)
    
    > Either way the test passes since the Status returned is the same, but it isn't a
very good test since the behavior isn't really defined. I think we are a bit too high-level
here for a unit test.
    
    I would be happy with a test that is not "human-level". That is, if you can write a test
showing that your interrupt/retry logic works, I would +1 that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message