Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
Message-ID: <git-pr-253-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback
Content-Type: text/plain
Date: Fri, 21 Apr 2017 20:02:33 +0000 (UTC)
archived-at: Fri, 21 Apr 2017 20:02:35 -0000

GitHub user ctubbsii opened a pull request:

    https://github.com/apache/accumulo/pull/253

    ACCUMULO-4086 Improve volume chooser fallback

    Implement a better fallback mechanism when the user's selected
    VolumeChooser implementation cannot be loaded or is not specified.
    Handles all such cases, including non-table scopes (logger), and
    per-table scopes.
    
    ****
    
    Note: this isn't quite ready for merging, but since I'm trying to proxy code written by somebody else, I think it'd be helpful to have it inspected/reviewed by more eyes. I tried to run the tests, but they hung (in Eclipse, at least). Keep in mind that this has been rebase'd from an older version of Accumulo, and probably needs a bit more work.
    
    The goal of this is described in [ACCUMULO-4086][1] and its parent task, but all I have is the implementation, and it's not entirely clear what the best design is, in order to make sure this particular implementation matches that design.
    
    Any and all feedback/assistance is helpful. However, I'm already aware documentation is significantly lacking.... will address that once the design and implementation is hammered out... and that's a bit fuzzy to me right now. For example, I see that the patch modifies the default configs, and it's not clear to me what design goal that achieves.
    
    [1]: https://issues.apache.org/jira/browse/ACCUMULO-4086

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ctubbsii/accumulo ACCUMULO-4086-volume-chooser-fallback

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #253
    
----
commit 1c81d6e44a4127ae74852bc8246396878d05cef6
Author: Christopher Tubbs <ctubbsii@apache.org>
Date:   2017-04-21T19:41:57Z

    ACCUMULO-4086 Improve volume chooser fallback
    
    Implement a better fallback mechanism when the user's selected
    VolumeChooser implementation cannot be loaded or is not specified.
    Handles all such cases, including non-table scopes (logger), and
    per-table scopes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---