Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8111B200C4D for ; Wed, 5 Apr 2017 17:22:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7FB22160B94; Wed, 5 Apr 2017 15:22:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C6858160B91 for ; Wed, 5 Apr 2017 17:22:56 +0200 (CEST) Received: (qmail 81194 invoked by uid 500); 5 Apr 2017 15:22:56 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 81183 invoked by uid 99); 5 Apr 2017 15:22:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Apr 2017 15:22:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9ECA1DFC8E; Wed, 5 Apr 2017 15:22:55 +0000 (UTC) From: milleruntime To: dev@accumulo.apache.org Reply-To: dev@accumulo.apache.org Message-ID: Subject: [GitHub] accumulo pull request #241: Discussion of Adam's ACCUMULO-3079: iterator sta... Content-Type: text/plain Date: Wed, 5 Apr 2017 15:22:55 +0000 (UTC) archived-at: Wed, 05 Apr 2017 15:22:57 -0000 GitHub user milleruntime opened a pull request: https://github.com/apache/accumulo/pull/241 Discussion of Adam's ACCUMULO-3079: iterator stack collapsing to improve performance Applied the changes from the patch submitted by Adam Fuchs on [ACCUMULO-3079](https://issues.apache.org/jira/browse/ACCUMULO-3079) to master. This PR is to bring these changes back into discussion. Questions for discussion: Do we want all/some of these changes? Should we leave WrappingIterator alone? Could some of these changes be more widely used across the other iterators/filters? I also included the performance tests (MikeTest) I used to measure the improvements; testStack was Adam's from JIRA ticket and testScan1 was one I wrote to use the new RFile interface. The improvements don't seem to be as drastic as Adam saw against 1.6 but I was able to consistently measure a 15% increase in the average number of scans per second. You can merge this pull request into a Git repository by running: $ git pull https://github.com/milleruntime/accumulo ACCUMULO-3079-all Alternatively you can review and apply these changes as the patch at: https://github.com/apache/accumulo/pull/241.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #241 ---- commit ef3e7dae2ffea2278a665423dd93d09e3cc83638 Author: Mike Miller Date: 2017-03-31T16:43:45Z ACCUMULO-3079: collapsed the iterator stack to improve performance ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---