Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: milleruntime <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-247-accumulo@git.apache.org>
In-Reply-To: <git-pr-247-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #247: ACCUMULO-3208 Integration test for the OrIterato...
Content-Type: text/plain
Message-Id: <20170411192950.E9B5DDF9FD@git1-us-west.apache.org>
Date: Tue, 11 Apr 2017 19:29:50 +0000 (UTC)
archived-at: Tue, 11 Apr 2017 19:29:53 -0000

Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/247#discussion_r110992809
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
    @@ -80,59 +113,103 @@ public int compareTo(TermSource o) {
           // sorted after they have been determined to be valid.
           return this.iter.getTopKey().compareColumnQualifier(o.iter.getTopKey().getColumnQualifier());
    --- End diff --
    
    You could add a comment to TermSource stating that the CQ is the docID for the term and is used for sorting.  Then note in the class comments that the inner class TermSource, is sortable by docID but this implementation is optimized and returns an unsorted list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---