Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-242-accumulo@git.apache.org>
In-Reply-To: <git-pr-242-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI
Content-Type: text/plain
Message-Id: <20170406195353.215B9E9627@git1-us-west.apache.org>
Date: Thu,  6 Apr 2017 19:53:53 +0000 (UTC)
archived-at: Thu, 06 Apr 2017 19:53:55 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/242#discussion_r110252576
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tservers/TabletServerResource.java ---
    @@ -0,0 +1,336 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.monitor.rest.tservers;
    +
    +import java.lang.management.ManagementFactory;
    +import java.security.MessageDigest;
    +import java.util.ArrayList;
    +import java.util.Base64;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +
    +import javax.ws.rs.Consumes;
    +import javax.ws.rs.GET;
    +import javax.ws.rs.POST;
    +import javax.ws.rs.Path;
    +import javax.ws.rs.PathParam;
    +import javax.ws.rs.Produces;
    +import javax.ws.rs.QueryParam;
    +import javax.ws.rs.WebApplicationException;
    +import javax.ws.rs.core.MediaType;
    +import javax.ws.rs.core.Response.Status;
    +
    +import org.apache.accumulo.core.Constants;
    +import org.apache.accumulo.core.client.impl.ClientContext;
    +import org.apache.accumulo.core.client.impl.Tables;
    +import org.apache.accumulo.core.conf.Property;
    +import org.apache.accumulo.core.data.impl.KeyExtent;
    +import org.apache.accumulo.core.master.thrift.MasterMonitorInfo;
    +import org.apache.accumulo.core.master.thrift.RecoveryStatus;
    +import org.apache.accumulo.core.master.thrift.TabletServerStatus;
    +import org.apache.accumulo.core.rpc.ThriftUtil;
    +import org.apache.accumulo.core.tabletserver.thrift.ActionStats;
    +import org.apache.accumulo.core.tabletserver.thrift.TabletClientService;
    +import org.apache.accumulo.core.tabletserver.thrift.TabletStats;
    +import org.apache.accumulo.core.trace.Tracer;
    +import org.apache.accumulo.core.util.AddressUtil;
    +import org.apache.accumulo.core.zookeeper.ZooUtil;
    +import org.apache.accumulo.monitor.Monitor;
    +import org.apache.accumulo.monitor.rest.master.MasterResource;
    +import org.apache.accumulo.server.client.HdfsZooInstance;
    +import org.apache.accumulo.server.master.state.DeadServerList;
    +import org.apache.accumulo.server.util.ActionStatsUpdator;
    +
    +import com.google.common.net.HostAndPort;
    +
    +/**
    + *
    + * Generates tserver lists as JSON objects
    + *
    + * @since 2.0.0
    + *
    + */
    +@Path("/tservers")
    +@Produces({MediaType.APPLICATION_JSON, MediaType.APPLICATION_XML})
    +public class TabletServerResource {
    +
    +  // Variable names become JSON keys
    +  private TabletStats total, historical;
    +
    +  /**
    +   * Generates tserver summary
    +   *
    +   * @return tserver summary
    +   */
    +  @GET
    +  public TabletServers getTserverSummary() {
    +    MasterMonitorInfo mmi = Monitor.getMmi();
    +    if (null == mmi) {
    +      throw new WebApplicationException(Status.INTERNAL_SERVER_ERROR);
    +    }
    +
    +    TabletServers tserverInfo = new TabletServers(mmi.tServerInfo.size());
    +    for (TabletServerStatus status : mmi.tServerInfo) {
    +      tserverInfo.addTablet(new TabletServer(status));
    +    }
    +
    +    tserverInfo.addBadTabletServer(new MasterResource().getTables());
    +
    +    return tserverInfo;
    +  }
    +
    +  /**
    +   * REST call to clear dead servers from list
    +   *
    +   * @param server
    +   *          Dead server to clear
    +   */
    +  @POST
    +  @Consumes(MediaType.TEXT_PLAIN)
    +  public void clearDeadServer(@QueryParam("server") String server) throws Exception {
    +    DeadServerList obit = new DeadServerList(ZooUtil.getRoot(Monitor.getContext().getInstance()) + Constants.ZDEADTSERVERS);
    +    obit.delete(server);
    +  }
    +
    +  /**
    +   * Generates a recovery tserver list
    +   *
    +   * @return Recovery tserver list
    +   */
    +  @Path("recovery")
    +  @GET
    +  public Map<String,List<Map<String,String>>> getTserverRecovery() {
    +
    +    Map<String,List<Map<String,String>>> jsonObj = new HashMap<String,List<Map<String,String>>>();
    +    List<Map<String,String>> recoveryList = new ArrayList<>();
    +    Map<String,String> recoveryObj = new HashMap<String,String>();
    +
    +    MasterMonitorInfo mmi = Monitor.getMmi();
    +    if (null == mmi) {
    +      throw new WebApplicationException(Status.INTERNAL_SERVER_ERROR);
    +    }
    +
    +    for (TabletServerStatus server : mmi.tServerInfo) {
    +      if (server.logSorts != null) {
    +        for (RecoveryStatus recovery : server.logSorts) {
    +          recoveryObj.put("server", AddressUtil.parseAddress(server.name, false).getHostText());
    +          recoveryObj.put("log", recovery.name);
    +          recoveryObj.put("time", Long.toString(recovery.runtime));
    +          recoveryObj.put("copySort", Double.toString(recovery.progress));
    +
    +          recoveryList.add(recoveryObj);
    +        }
    +      }
    +    }
    +
    +    jsonObj.put("recoveryList", recoveryList);
    +
    +    return jsonObj;
    +  }
    +
    +  /**
    +   * Generates details for the selected tserver
    +   *
    +   * @param tserverAddr
    +   *          TServer name
    +   * @return TServer details
    +   */
    +  @Path("{address}")
    +  @GET
    +  public TabletServerSummary getTserverDetails(@PathParam("address") String tserverAddr) throws Exception {
    +
    +    String tserverAddress = tserverAddr;
    +
    +    boolean tserverExists = false;
    +    if (tserverAddress != null && tserverAddress.isEmpty() == false) {
    +      for (TabletServerStatus ts : Monitor.getMmi().getTServerInfo()) {
    +        if (tserverAddress.equals(ts.getName())) {
    +          tserverExists = true;
    +          break;
    +        }
    +      }
    +    }
    +
    +    if (tserverAddress == null || tserverAddress.isEmpty() || tserverExists == false) {
    +
    +      return null;
    +    }
    +
    +    double totalElapsedForAll = 0;
    +    double splitStdDev = 0;
    +    double minorStdDev = 0;
    +    double minorQueueStdDev = 0;
    +    double majorStdDev = 0;
    +    double majorQueueStdDev = 0;
    +    double currentMinorAvg = 0;
    +    double currentMajorAvg = 0;
    +    double currentMinorStdDev = 0;
    +    double currentMajorStdDev = 0;
    +    total = new TabletStats(null, new ActionStats(), new ActionStats(), new ActionStats(), 0, 0, 0, 0);
    +    HostAndPort address = HostAndPort.fromString(tserverAddress);
    +    historical = new TabletStats(null, new ActionStats(), new ActionStats(), new ActionStats(), 0, 0, 0, 0);
    +    List<TabletStats> tsStats = new ArrayList<>();
    +
    +    try {
    +      ClientContext context = Monitor.getContext();
    +      TabletClientService.Client client = ThriftUtil.getClient(new TabletClientService.Client.Factory(), address, context);
    +      try {
    +        for (String tableId : Monitor.getMmi().tableMap.keySet()) {
    +          tsStats.addAll(client.getTabletStats(Tracer.traceInfo(), context.rpcCreds(), tableId));
    +        }
    +        historical = client.getHistoricalStats(Tracer.traceInfo(), context.rpcCreds());
    +      } finally {
    +        ThriftUtil.returnClient(client);
    +      }
    +    } catch (Exception e) {
    +      return null;
    +    }
    +
    +    List<CurrentOperations> currentOps = doCurrentOperations(tsStats);
    +
    +    if (total.minors.num != 0)
    +      currentMinorAvg = (long) (total.minors.elapsed / total.minors.num);
    +    if (total.minors.elapsed != 0 && total.minors.num != 0)
    +      currentMinorStdDev = stddev(total.minors.elapsed, total.minors.num, total.minors.sumDev);
    +    if (total.majors.num != 0)
    +      currentMajorAvg = total.majors.elapsed / total.majors.num;
    +    if (total.majors.elapsed != 0 && total.majors.num != 0 && total.majors.elapsed > total.majors.num)
    +      currentMajorStdDev = stddev(total.majors.elapsed, total.majors.num, total.majors.sumDev);
    +
    +    ActionStatsUpdator.update(total.minors, historical.minors);
    +    ActionStatsUpdator.update(total.majors, historical.majors);
    +    totalElapsedForAll += total.majors.elapsed + historical.splits.elapsed + total.minors.elapsed;
    +
    +    minorStdDev = stddev(total.minors.elapsed, total.minors.num, total.minors.sumDev);
    +    minorQueueStdDev = stddev(total.minors.queueTime, total.minors.num, total.minors.queueSumDev);
    +    majorStdDev = stddev(total.majors.elapsed, total.majors.num, total.majors.sumDev);
    +    majorQueueStdDev = stddev(total.majors.queueTime, total.majors.num, total.majors.queueSumDev);
    +    splitStdDev = stddev(historical.splits.num, historical.splits.elapsed, historical.splits.sumDev);
    +
    +    TabletServerDetailInformation details = doDetails(address, tsStats.size());
    +
    +    List<AllTimeTabletResults> allTime = doAllTimeResults(majorQueueStdDev, minorQueueStdDev, totalElapsedForAll, splitStdDev, majorStdDev, minorStdDev);
    +
    +    CurrentTabletResults currentRes = doCurrentTabletResults(currentMinorAvg, currentMinorStdDev, currentMajorAvg, currentMajorStdDev);
    +
    +    TabletServerSummary tserverDetails = new TabletServerSummary(details, allTime, currentRes, currentOps);
    +
    +    return tserverDetails;
    +  }
    +
    +  private static final int concurrentScans = Monitor.getContext().getConfiguration().getCount(Property.TSERV_READ_AHEAD_MAXCONCURRENT);
    --- End diff --
    
    Dynamic reaction to properties seems out of scope for this issue. Couldn't this be done in a future task? I doubt the current monitor does this (well).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---