Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-242-accumulo@git.apache.org>
In-Reply-To: <git-pr-242-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI
Content-Type: text/plain
Message-Id: <20170406043553.47D55DFC8E@git1-us-west.apache.org>
Date: Thu,  6 Apr 2017 04:35:53 +0000 (UTC)
archived-at: Thu, 06 Apr 2017 04:35:57 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/242#discussion_r110074364
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java ---
    @@ -118,19 +98,17 @@ public void start() {
         }
       }
     
    -  public void stop() {
    +  private void stop() {
    --- End diff --
    
    why private?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---