Return-Path: <dev-return-17920-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id C284B200C4D
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  5 Apr 2017 16:58:17 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id C12E3160B94; Wed,  5 Apr 2017 14:58:17 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 3AC0F160B91
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  5 Apr 2017 16:58:17 +0200 (CEST)
Received: (qmail 13704 invoked by uid 500); 5 Apr 2017 14:58:16 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 13693 invoked by uid 99); 5 Apr 2017 14:58:16 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Apr 2017 14:58:16 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 03A93DFC8E; Wed,  5 Apr 2017 14:58:16 +0000 (UTC)
From: mikewalch <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-239-accumulo@git.apache.org>
In-Reply-To: <git-pr-239-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #239: ACCUMULO-4618 Enforce dependency analysis during...
Content-Type: text/plain
Message-Id: <20170405145816.03A93DFC8E@git1-us-west.apache.org>
Date: Wed,  5 Apr 2017 14:58:16 +0000 (UTC)
archived-at: Wed, 05 Apr 2017 14:58:17 -0000

Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/239#discussion_r109939194
  
    --- Diff: server/monitor/pom.xml ---
    @@ -105,23 +113,13 @@
           <artifactId>slf4j-api</artifactId>
         </dependency>
         <dependency>
    -      <groupId>org.eclipse.jetty</groupId>
    -      <artifactId>jetty-http</artifactId>
    -      <scope>runtime</scope>
    -    </dependency>
    -    <dependency>
    -      <groupId>org.eclipse.jetty</groupId>
    -      <artifactId>jetty-io</artifactId>
    -      <scope>runtime</scope>
    --- End diff --
    
    They were being marked as declared but unused.  They are pulled in by the `jetty-server` jar so I think this removal is fine.
    
    ```
    [INFO] +- org.eclipse.jetty:jetty-server:jar:9.2.17.v20160517:compile
    [INFO] |  +- org.eclipse.jetty:jetty-http:jar:9.2.17.v20160517:compile
    [INFO] |  \- org.eclipse.jetty:jetty-io:jar:9.2.17.v20160517:compile
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---