Return-Path: <dev-return-17900-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 3749B200C3C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon,  3 Apr 2017 22:43:36 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 35CD8160B9C; Mon,  3 Apr 2017 20:43:36 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id A3AFE160B8D
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  3 Apr 2017 22:43:35 +0200 (CEST)
Received: (qmail 94617 invoked by uid 500); 3 Apr 2017 20:43:34 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 94591 invoked by uid 99); 3 Apr 2017 20:43:34 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 20:43:34 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 77064DFBA4; Mon,  3 Apr 2017 20:43:34 +0000 (UTC)
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-237-accumulo@git.apache.org>
In-Reply-To: <git-pr-237-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #237: ACCUMULO-3521: minor improvements to iterators
Content-Type: text/plain
Message-Id: <20170403204334.77064DFBA4@git1-us-west.apache.org>
Date: Mon,  3 Apr 2017 20:43:34 +0000 (UTC)
archived-at: Mon, 03 Apr 2017 20:43:36 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/237#discussion_r109517652
  
    --- Diff: core/src/test/java/org/apache/accumulo/core/iterators/user/CombinerTest.java ---
    @@ -922,4 +923,49 @@ public void testDeleteHandling() throws Exception {
         runDeleteHandlingTest(input, expected, null, paritalMajcIe, ".*ERROR.*SummingCombiner.*ACCUMULO-2232.*");
         runDeleteHandlingTest(input, expected, null, fullMajcIe, ".*ERROR.*SummingCombiner.*ACCUMULO-2232.*");
       }
    +
    +  /**
    +   * Tests the Lossy option will ignore errors in TypedValueCombiner. Uses SummingArrayCombiner to generate error.
    +   */
    +  @Test
    +  public void testLossyOption() throws IOException, IllegalAccessException, InstantiationException {
    +    Encoder<List<Long>> encoder = SummingArrayCombiner.VarLongArrayEncoder.class.newInstance();
    --- End diff --
    
    Is there a reason could not do `new VarLongArrayEncoder()`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---