accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #255: ACCUMULO-4365: Fix trace test in ShellServerIT
Date Fri, 28 Apr 2017 14:22:09 GMT
GitHub user milleruntime opened a pull request:

    https://github.com/apache/accumulo/pull/255

    ACCUMULO-4365: Fix trace test in ShellServerIT

    This test has been frustrating for some time now... After spending some time looking into
a potential bug (possibly one similar to ACCUMULO-4191) I don't think a bug actually exists.
    
    This test looked for "sendMutations" traces generated from the insert command but ACCUMULO-1755
changed the way mutations were handled in TabletServerBatchWriter. The multithreaded nature
of mutations are now too unpredictable and time sensitive to reliably look for "sendMutations"
traces here. 
    
    Aside from ignoring the test, this is the best solution I can come up with...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/milleruntime/accumulo ACCUMULO-4365

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #255
    
----
commit 18f99f38ecfc54c2b062a8f9c08477fc65f91a11
Author: Mike Miller <mmiller@apache.org>
Date:   2017-04-28T14:12:12Z

    ACCUMULO-4365: Fix trace test in ShellServerIT

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message