accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #241: Discussion of Adam's ACCUMULO-3079: iterator sta...
Date Wed, 05 Apr 2017 15:22:55 GMT
GitHub user milleruntime opened a pull request:

    https://github.com/apache/accumulo/pull/241

    Discussion of Adam's ACCUMULO-3079: iterator stack collapsing to improve performance

    Applied the changes from the patch submitted by Adam Fuchs on [ACCUMULO-3079](https://issues.apache.org/jira/browse/ACCUMULO-3079)
to master.  This PR is to bring these changes back into discussion.  
    
    Questions for discussion: Do we want all/some of these changes? Should we leave WrappingIterator
alone?  Could some of these changes be more widely used across the other iterators/filters?
    
    I also included the performance tests (MikeTest) I used to measure the improvements; testStack
was Adam's from JIRA ticket and testScan1 was one I wrote to use the new RFile interface.
The improvements don't seem to be as drastic as Adam saw against 1.6 but I was able to consistently
measure a 15% increase in the average number of scans per second.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/milleruntime/accumulo ACCUMULO-3079-all

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #241
    
----
commit ef3e7dae2ffea2278a665423dd93d09e3cc83638
Author: Mike Miller <mmiller@apache.org>
Date:   2017-03-31T16:43:45Z

    ACCUMULO-3079: collapsed the iterator stack to improve performance

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message