accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback
Date Tue, 25 Apr 2017 20:09:57 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/253#discussion_r113297447
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
    @@ -191,7 +191,7 @@
           + "server-internal scheduled tasks"),
       // If you update the default type, be sure to update the default used for initialization
failures in VolumeManagerImpl
       @Experimental
    -  GENERAL_VOLUME_CHOOSER("general.volume.chooser", "org.apache.accumulo.server.fs.PerTableVolumeChooser",
PropertyType.CLASSNAME,
    +  GENERAL_VOLUME_CHOOSER("general.volume.chooser", "org.apache.accumulo.server.fs.RandomVolumeChooser",
PropertyType.CLASSNAME,
    --- End diff --
    
    I'm actually questioning whether this is necessary myself. The original intent of the
parent issue was to ban certain volumes from being used entirely (unless explicitly desired).
This change was to help provide a sane fall-back scenario, but I'm not sure it's necessary
if we change things to be a hard-fail in the case of misconfiguration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message