accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <>
Subject [GitHub] accumulo pull request #244: Discuss ACCUMULO-3079: collapsing the iterator s...
Date Tue, 25 Apr 2017 18:33:06 GMT
Github user keith-turner commented on a diff in the pull request:
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/ ---
    @@ -683,13 +683,6 @@ public void setInterruptFlag(AtomicBoolean flag) {
         private SourceSwitchingIterator ssi;
         private MemoryDataSource mds;
    -    @Override
    -    protected SortedKeyValueIterator<Key,Value> getSource() {
    -      if (closed.get())
    -        throw new IllegalStateException("Memory iterator is closed");
    -      return super.getSource();
    -    }
    --- End diff --
    I did a bit of research into the implications of removing this sanity check.  The case
where the check would have triggered is when scan iterators are used after Accumulo has finished
using the iterator stack.  If that's what we want to check for, this is probably not the best
place to do it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message