accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #244: Discuss ACCUMULO-3079: collapsing the iterator s...
Date Mon, 24 Apr 2017 21:30:18 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/244#discussion_r113061466
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java ---
    @@ -683,13 +683,6 @@ public void setInterruptFlag(AtomicBoolean flag) {
         private SourceSwitchingIterator ssi;
         private MemoryDataSource mds;
     
    -    @Override
    -    protected SortedKeyValueIterator<Key,Value> getSource() {
    -      if (closed.get())
    -        throw new IllegalStateException("Memory iterator is closed");
    -      return super.getSource();
    -    }
    -
    --- End diff --
    
    It could just be a margin of error or the JMH test I wrote: https://github.com/milleruntime/jmh-test/blob/6cd94569bbecda42181b6b7d7101e0770ef00d7f/src/main/java/org/sample/InMemoryMapBenchmark.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message