accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #244: Discuss ACCUMULO-3079: collapsing the iterator s...
Date Fri, 21 Apr 2017 20:16:27 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/244#discussion_r112761301
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java ---
    @@ -683,13 +683,6 @@ public void setInterruptFlag(AtomicBoolean flag) {
         private SourceSwitchingIterator ssi;
         private MemoryDataSource mds;
     
    -    @Override
    -    protected SortedKeyValueIterator<Key,Value> getSource() {
    -      if (closed.get())
    -        throw new IllegalStateException("Memory iterator is closed");
    -      return super.getSource();
    -    }
    -
    --- End diff --
    
    I could see removing that helping performance, because its reading a volatile.  However
it is a sanity check.  Might be worthwhile testing this one on its own before removing to
see if there is a benefit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message