accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <>
Subject [GitHub] accumulo pull request #244: Discuss ACCUMULO-3079: collapsing the iterator s...
Date Fri, 21 Apr 2017 18:59:02 GMT
Github user milleruntime commented on a diff in the pull request:
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/ ---
    @@ -683,13 +683,6 @@ public void setInterruptFlag(AtomicBoolean flag) {
         private SourceSwitchingIterator ssi;
         private MemoryDataSource mds;
    -    @Override
    -    protected SortedKeyValueIterator<Key,Value> getSource() {
    -      if (closed.get())
    -        throw new IllegalStateException("Memory iterator is closed");
    -      return super.getSource();
    -    }
    --- End diff --
    Without the WrappingIterator changes, I don't think we gain anything from this change...
we just lose the closed check.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message