accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scubafuchs <>
Subject [GitHub] accumulo pull request #244: Discuss ACCUMULO-3079: collapsing the iterator s...
Date Thu, 20 Apr 2017 22:29:46 GMT
Github user scubafuchs commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/
    @@ -58,21 +58,21 @@ protected void setSource(SortedKeyValueIterator<Key,Value> source)
       public Key getTopKey() {
         if (seenSeek == false)
           throw new IllegalStateException("never been seeked");
    -    return getSource().getTopKey();
    +    return source.getTopKey();
    --- End diff --
    No, LightWrappingIterator is a user-level iterator, so it supports a no-argument constructor
and non-final source to be compatible with the initialization via init method. It basically
just removes some check, doesn't call getSource(), and exposes the source field as protected
instead of private.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message