accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scubafuchs <...@git.apache.org>
Subject [GitHub] accumulo pull request #244: Discuss ACCUMULO-3079: collapsing the iterator s...
Date Thu, 20 Apr 2017 21:08:38 GMT
Github user scubafuchs commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/244#discussion_r112561404
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/WrappingIterator.java
---
    @@ -58,21 +58,21 @@ protected void setSource(SortedKeyValueIterator<Key,Value> source)
{
       public Key getTopKey() {
         if (seenSeek == false)
           throw new IllegalStateException("never been seeked");
    -    return getSource().getTopKey();
    +    return source.getTopKey();
    --- End diff --
    
    In Sqrrl we use a LightWrappingIterator that does this. I'd be in favor of deprecating
the WrappingIterator, but we might want to couple that with the bigger iterator rewrite project
(ACCUMULO-3751).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message