accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scubafuchs <...@git.apache.org>
Subject [GitHub] accumulo pull request #244: Discuss ACCUMULO-3079: collapsing the iterator s...
Date Thu, 20 Apr 2017 18:37:20 GMT
Github user scubafuchs commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/244#discussion_r112529455
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java ---
    @@ -746,50 +746,45 @@ public boolean hasTop() {
         @Override
         public void next() throws IOException {
    --- End diff --
    
    A bunch of these changes are meant to reduce the call stack size and make the jit's job
easier. I don't remember if the jit has trouble with optimizing this call in particular, or
whether that has changed since the original tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message