accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lstav <...@git.apache.org>
Subject [GitHub] accumulo issue #242: ACCUMULO-2181/3005 REST API and new Monitor UI
Date Thu, 13 Apr 2017 23:44:20 GMT
Github user lstav commented on the issue:

    https://github.com/apache/accumulo/pull/242
  
    @joshelser Just a couple of things responding to your comments:
    
    > I think there should be an "Apache Accumulo" in the top-left of the header (instead
of the instance name). Perhaps center the instance name instead? Right now we have 0 branding
of our product. We should do better here (Name, Accumulo logo, ASF logo, etc). Could easily
put something into the footer.
    
    One of the design changes I made was to remove the footer (makes it for a cleaner look
on large tables) and move it to the "About" section. However, we could add the Accumulo logo
later on to the header (maybe even set a link to the Accumulo website?).
    
    > Auto-refresh also appears to make 13 ajax calls per refresh which is pretty excessive
at a refresh of 5s. We have the logic broken up which is nice, but when we're refreshing all
of these, we should minimize the number of ajax calls we're making (get all the data in one
call)
    
    I didn't think of this until I was wrapping up, but it would be good to make an issue
about this to simplify those calls. I believe the 13 calls happen only on the overview (since
we are getting all the information for the plots), but in other pages we also do multiple
calls (like in the master page). Thanks for pointing it out.
    
    > On the tables view, why do "default" and "accumulo" get auto-added when I select
"all"? This seems repetitive.
    
    "default" != "accumulo". The "default" namespace is the one where created tables get "assigned"
to if the user didn't specify a namespace, the "accumulo" namespace I believe is just for
the Replication, Root, and Metadata tables (could be mistaken?).
    
    > Is it possible to create some docs about the REST API and publish those with the
monitor? We have this great API but no information about the calls and the data. The XML and
JSON stuff is there for old users, but we should try to push the new people to the new REST
calls.
    
    I tried to write some Java documentation that would be useful for generating the JavaDocs,
but it might be good for someone with more knowledge of Accumulo (and Java) to check that
the wording is good for it.
    
    > Not all table column headers have tool-tips. We should make a pass for clarity/simplicity.
    
    The tooltips replace the "Show legend" section of the old Monitor, and not all columns
had explanations. @ctubbsii had mentioned that we should revisit the summaries in the future
to clean them up (I didn't change the wording from the original Monitor).
    
    > Edit: also, I'm +1 on a merge. Great job seeing this through, @lstav
    
    Thanks!
    
    Most of the rest of the things you mention are fixes that could be done in a future issue
(mostly changes in the HTML or JavaScript code.. no need to touch the Java code for these
anymore! Woo!).
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message