accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI
Date Thu, 13 Apr 2017 21:56:51 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/242#discussion_r111496086
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java
---
    @@ -118,19 +98,17 @@ public void start() {
         }
       }
     
    -  public void stop() {
    +  private void stop() {
    --- End diff --
    
    sgtm. Long-term we should be moving to treating the objects that can be started/stopped
with some sort of Service interface abstraction (e.g. TabletServer, Monitor, GC), but doesn't
need to happen here and such a refactoring could invalidate anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message