accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <>
Subject [GitHub] accumulo pull request #247: ACCUMULO-3208 Integration test for the OrIterato...
Date Wed, 12 Apr 2017 14:00:31 GMT
Github user milleruntime commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/ ---
    @@ -39,29 +39,44 @@
     import org.slf4j.LoggerFactory;
    - * An iterator that handles "OR" query constructs on the server side. This code has been
adapted/merged from Heap and Multi Iterators.
    + * An iterator that provides a sorted-iteration of column qualifiers for a set of column
families in a row.
    + * It is important to note that this iterator <em>does not</em> adhere to
the contract set forth by the
    + * {@link SortedKeyValueIterator}. It returns Keys in {@code row+colqual} order instead
    + * {@code row+colfam+colqual} order. This is required for the implementation of this
iterator (to work
    + * in conjunction with the {@code IntersectingIterator}) but is a code-smell. This iterator
should only
    --- End diff --
    Yes it was tongue-in-cheek. I had to google "code smell" since I hadn't heard that phrase
before but I don't think its offensive.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message