accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #247: ACCUMULO-3208 Integration test for the OrIterato...
Date Tue, 11 Apr 2017 16:30:40 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/247#discussion_r110950549
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
    @@ -30,36 +33,66 @@
     import org.apache.accumulo.core.data.Key;
     import org.apache.accumulo.core.data.Range;
     import org.apache.accumulo.core.data.Value;
    +import org.apache.commons.lang.StringUtils;
     import org.apache.hadoop.io.Text;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
     
     /**
      * An iterator that handles "OR" query constructs on the server side. This code has been
adapted/merged from Heap and Multi Iterators.
    --- End diff --
    
    > This code has been adapted/merged from Heap and Multi Iterators.
    
    It is not clear to me what this means.  Does this add anything for someone with a deep
understanding of Heap and Multi iterators?  If not, maybe just remove this sentence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message