accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI
Date Fri, 07 Apr 2017 20:21:32 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/242#discussion_r110470413
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tservers/ServerShuttingDownInformation.java
---
    @@ -14,25 +14,32 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.accumulo.monitor.util.celltypes;
    +package org.apache.accumulo.monitor.rest.tservers;
     
    -import java.io.Serializable;
    -import java.util.Comparator;
    +import javax.xml.bind.annotation.XmlAttribute;
     
    -public abstract class CellType<T> implements Comparator<T>, Serializable
{
    -
    -  private static final long serialVersionUID = 1L;
    -  private boolean sortable = true;
    -
    -  abstract public String alignment();
    +/**
    + *
    + * Generates a tserver shutting down
    + *
    + * @since 2.0.0
    + *
    + */
    +public class ServerShuttingDownInformation {
    --- End diff --
    
    +1 Much better name


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message