accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lstav <...@git.apache.org>
Subject [GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI
Date Fri, 07 Apr 2017 19:59:40 GMT
Github user lstav commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/242#discussion_r110470726
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/XMLResource.java
---
    @@ -0,0 +1,67 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.monitor.rest;
    +
    +import javax.ws.rs.GET;
    +import javax.ws.rs.Path;
    +import javax.ws.rs.Produces;
    +import javax.ws.rs.WebApplicationException;
    +import javax.ws.rs.core.MediaType;
    +import javax.ws.rs.core.Response.Status;
    +
    +import org.apache.accumulo.core.master.thrift.MasterMonitorInfo;
    +import org.apache.accumulo.core.master.thrift.TabletServerStatus;
    +import org.apache.accumulo.monitor.Monitor;
    +import org.apache.accumulo.monitor.rest.master.MasterResource;
    +import org.apache.accumulo.monitor.rest.tables.TablesResource;
    +import org.apache.accumulo.monitor.rest.tservers.TabletServer;
    +
    +/**
    + *
    + * Responsible for generating an XML summary of the Monitor
    + *
    + * @since 2.0.0
    + *
    + */
    +@Path("/")
    +@Produces({MediaType.APPLICATION_JSON, MediaType.APPLICATION_XML})
    +public class XMLResource {
    +
    +  /**
    +   * Generates an XML summary of the Monitor
    +   *
    +   * @return XML summary
    +   */
    +  @GET
    +  public XMLInformation getXMLInformation() {
    +
    +    MasterMonitorInfo mmi = Monitor.getMmi();
    +    if (null == mmi) {
    +      throw new WebApplicationException(Status.INTERNAL_SERVER_ERROR);
    +    }
    +
    +    // Add Monitor information
    +    XMLInformation xml = new XMLInformation(mmi.tServerInfo.size(), new MasterResource().getTables(),
new TablesResource().getTables());
    +
    +    // Add tserver information
    +    for (TabletServerStatus status : mmi.tServerInfo) {
    +      xml.addTablet(new TabletServer(status));
    --- End diff --
    
    @joshelser I'm not sure I understand what is the confusion, is it just for the XMLResource
class? Or is it anywhere where TabletServer exists? If it is the second one, keep in mind
that none of the objects of the REST call are the actual instances, I created new classes
specifically for the REST (in order to store variables that will serve as JSON keys). If it
is something else, could you elaborate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message