accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #240: ACCUMULO-4618 Updates from additional code revie...
Date Thu, 06 Apr 2017 22:59:44 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/240#discussion_r110286306
  
    --- Diff: maven-plugin/pom.xml ---
    @@ -68,6 +68,7 @@
         <dependency>
           <groupId>xml-apis</groupId>
           <artifactId>xml-apis</artifactId>
    +      <scope>provided</scope>
    --- End diff --
    
    ```patch
    diff --git a/pom.xml b/pom.xml
    index 801a6e6..0f753c9 100644
    --- a/pom.xml
    +++ b/pom.xml
    @@ -389,6 +389,12 @@
             <groupId>org.apache.hadoop</groupId>
             <artifactId>hadoop-client</artifactId>
             <version>${hadoop.version}</version>
    +        <exclusions>
    +          <exclusion>
    +            <groupId>xerces</groupId>
    +            <artifactId>xercesImpl</artifactId>
    +          </exclusion>
    +        </exclusions>
           </dependency>
           <dependency>
             <groupId>org.apache.hadoop</groupId>
    @@ -399,6 +405,12 @@
             <groupId>org.apache.hadoop</groupId>
             <artifactId>hadoop-minicluster</artifactId>
             <version>${hadoop.version}</version>
    +        <exclusions>
    +          <exclusion>
    +            <groupId>xerces</groupId>
    +            <artifactId>xercesImpl</artifactId>
    +          </exclusion>
    +        </exclusions>
           </dependency>
           <dependency>
             <groupId>org.apache.hadoop</groupId>
    @@ -555,11 +567,6 @@
             <artifactId>slf4j-nop</artifactId>
             <version>${slf4j.version}</version>
           </dependency>
    -      <dependency>
    -        <groupId>xml-apis</groupId>
    -        <artifactId>xml-apis</artifactId>
    -        <version>1.3.04</version>
    -      </dependency>
         </dependencies>
       </dependencyManagement>
       <build>
    diff --git a/maven-plugin/pom.xml b/maven-plugin/pom.xml
    index fa38dfc..9c9f1f9 100644
    --- a/maven-plugin/pom.xml
    +++ b/maven-plugin/pom.xml
    @@ -65,10 +65,6 @@
           <groupId>org.apache.maven.plugin-tools</groupId>
           <artifactId>maven-plugin-annotations</artifactId>
         </dependency>
    -    <dependency>
    -      <groupId>xml-apis</groupId>
    -      <artifactId>xml-apis</artifactId>
    -    </dependency>
       </dependencies>
       <build>
         <plugins>
    diff --git a/server/base/pom.xml b/server/base/pom.xml
    index 3554c14..65575db 100644
    --- a/server/base/pom.xml
    +++ b/server/base/pom.xml
    @@ -105,10 +105,6 @@
           <artifactId>slf4j-api</artifactId>
         </dependency>
         <dependency>
    -      <groupId>xml-apis</groupId>
    -      <artifactId>xml-apis</artifactId>
    -    </dependency>
    -    <dependency>
           <groupId>junit</groupId>
           <artifactId>junit</artifactId>
           <scope>test</scope>
    diff --git a/start/pom.xml b/start/pom.xml
    index b9bdec8..85e22fc 100644
    --- a/start/pom.xml
    +++ b/start/pom.xml
    @@ -51,10 +51,6 @@
           <artifactId>slf4j-api</artifactId>
         </dependency>
         <dependency>
    -      <groupId>xml-apis</groupId>
    -      <artifactId>xml-apis</artifactId>
    -    </dependency>
    -    <dependency>
           <groupId>junit</groupId>
           <artifactId>junit</artifactId>
           <scope>test</scope>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message