accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lstav <...@git.apache.org>
Subject [GitHub] accumulo issue #242: ACCUMULO-2181/3005 REST API and new Monitor UI
Date Thu, 06 Apr 2017 17:13:07 GMT
Github user lstav commented on the issue:

    https://github.com/apache/accumulo/pull/242
  
    >> I changed to use the public variables at the suggestion of @ctubbsii, but we
could discuss the best approach and change it to that. 
    >>
    > Ok. Mostly I was thinking that if we are moving these towards being publicly consumable,
it would be better if we encapsulate the state and just expose it via methods (that gives
us more flexibility).
    >
    I understand, I'll discuss with him the reason he suggested otherwise (could have been
the initial implementation).
    
    >>I tested on both FF and Chrome, I couldn't get the proxy to work for IE so I haven't
been able to test it.
    >>
    >Ok, this would be good to keep in mind before merging. IE still has a bit of prevalence
in "the enterprise". We should perform some diligence before merge to make sure that we aren't
shipping something entirely busted on the major IE versions.
    >
    OK, I'll try to test it on IE, I believe that most of the libraries I used can be used
since IE8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message