accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI
Date Wed, 05 Apr 2017 20:44:22 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/242#discussion_r110019365
  
    --- Diff: server/monitor/src/main/resources/templates/overview.ftl ---
    @@ -0,0 +1,90 @@
    +<#--
    +  Licensed to the Apache Software Foundation (ASF) under one or more
    +  contributor license agreements.  See the NOTICE file distributed with
    +  this work for additional information regarding copyright ownership.
    +  The ASF licenses this file to You under the Apache License, Version 2.0
    +  (the "License"); you may not use this file except in compliance with
    +  the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +  Unless required by applicable law or agreed to in writing, software
    +  distributed under the License is distributed on an "AS IS" BASIS,
    +  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  See the License for the specific language governing permissions and
    +  limitations under the License.
    +-->
    +      <div><h3>${title}</h3></div>
    +      <br>
    +      <div class="center-block">
    +        <table class="overview-table">
    --- End diff --
    
    It would be really nice if this page and others used [bootstrap's grid system](http://getbootstrap.com/css/#grid)
(rather than `<table>` tags to structure the page).  If they did, the charts and tables
would collapse into a single column as screen size of the browser shrinks.  You can test this
with a desktop browser.  Check out the Accumulo website for an example.  The bootstrap code
is very simple.  Something like below:
    
    ```html
    <div class="container">
      <div class="row">
        <div class="col-md-6">Accumulo master table html</div>
        <div class="col-md-6">Zookeeper table html</div>
      </div> 
      <div class="row">
        <div class="col-md-6">Chart 1 html</div>
        <div class="col-md-6">Chart 2 html</div>
      </div> 
    </div>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message