accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #239: ACCUMULO-4618 Enforce dependency analysis during...
Date Tue, 04 Apr 2017 22:41:52 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/239#discussion_r109793616
  
    --- Diff: maven-plugin/pom.xml ---
    @@ -66,9 +66,8 @@
           <artifactId>maven-plugin-annotations</artifactId>
         </dependency>
         <dependency>
    -      <groupId>junit</groupId>
    -      <artifactId>junit</artifactId>
    -      <scope>test</scope>
    +      <groupId>xml-apis</groupId>
    +      <artifactId>xml-apis</artifactId>
    --- End diff --
    
    Where does this one come from? These APIs are built-in to the JDK. At the very least,
this should probably be marked "provided", but it can get a [lot more complicated than that][1].
    
    [1]: http://stackoverflow.com/questions/11677572/dealing-with-xerces-hell-in-java-maven


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message