accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #237: ACCUMULO-3521: minor improvements to iterators
Date Mon, 03 Apr 2017 21:28:42 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/237#discussion_r109529174
  
    --- Diff: core/src/test/java/org/apache/accumulo/core/iterators/user/CombinerTest.java
---
    @@ -922,4 +923,49 @@ public void testDeleteHandling() throws Exception {
         runDeleteHandlingTest(input, expected, null, paritalMajcIe, ".*ERROR.*SummingCombiner.*ACCUMULO-2232.*");
         runDeleteHandlingTest(input, expected, null, fullMajcIe, ".*ERROR.*SummingCombiner.*ACCUMULO-2232.*");
       }
    +
    +  /**
    +   * Tests the Lossy option will ignore errors in TypedValueCombiner. Uses SummingArrayCombiner
to generate error.
    +   */
    +  @Test
    +  public void testLossyOption() throws IOException, IllegalAccessException, InstantiationException
{
    +    Encoder<List<Long>> encoder = SummingArrayCombiner.VarLongArrayEncoder.class.newInstance();
    --- End diff --
    
    Whoops... weird copy and paste hold over. Fixed in 4262a314ce37d822ec96030872f10c90a8b18d8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message