accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #237: ACCUMULO-3521: minor improvements to iterators
Date Mon, 03 Apr 2017 20:43:34 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/237#discussion_r109519640
  
    --- Diff: core/src/test/java/org/apache/accumulo/core/iterators/FirstEntryInRowIteratorTest.java
---
    @@ -53,30 +54,33 @@ private static long process(TreeMap<Key,Value> sourceMap, TreeMap<Key,Value>
res
       public void test() throws IOException {
         TreeMap<Key,Value> sourceMap = new TreeMap<>();
         Value emptyValue = new Value("".getBytes());
    +    IteratorSetting iteratorSetting = new IteratorSetting(1, FirstEntryInRowIterator.class);
    +    FirstEntryInRowIterator.setNumScansBeforeSeek(iteratorSetting, 10);
    --- End diff --
    
    Will the test fail if this is not set to properly?  If not, could call iteratorSetting.getOptions()
after this and check if it was really set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message