Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-235-accumulo@git.apache.org>
In-Reply-To: <git-pr-235-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...
Content-Type: text/plain
Message-Id: <20170323172546.22326DFF77@git1-us-west.apache.org>
Date: Thu, 23 Mar 2017 17:25:46 +0000 (UTC)
archived-at: Thu, 23 Mar 2017 17:25:48 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/235#discussion_r107732253
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java ---
    @@ -209,13 +209,19 @@ static public long getMemoryInBytes(String str) {
             case 'B':
               multiplier = 0;
               break;
    +        case '%':
    --- End diff --
    
    > Even if we limit percentage, users can still misconfigure things by setting fixed memory values that are too high or low for that property.
    
    Thats true.  Using types just narrows the set of possible mistakes, it does not eliminate mistakes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---