Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: mikewalch <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-230-accumulo@git.apache.org>
In-Reply-To: <git-pr-230-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #230: Accumulo-4599 Simplify how accumulo script adds ...
Content-Type: text/plain
Message-Id: <20170308160805.5424EDFA6F@git1-us-west.apache.org>
Date: Wed,  8 Mar 2017 16:08:05 +0000 (UTC)
archived-at: Wed, 08 Mar 2017 16:08:07 -0000

Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/230#discussion_r104952630
  
    --- Diff: assemble/bin/accumulo ---
    @@ -59,43 +59,22 @@ function main() {
       export ACCUMULO_CONF_DIR="$conf"
     
       # Verify setting in accumulo-env.sh
    -
       : "${JAVA_OPTS:?"variable is not set in accumulo-env.sh"}"
       : "${ACCUMULO_LOG_DIR:?"variable is not set in accumulo-env.sh"}"
       mkdir -p "${ACCUMULO_LOG_DIR}" 2>/dev/null
    -  verify_env_dir "ACCUMULO_LOG_DIR" "${ACCUMULO_LOG_DIR}"
       verify_env_dir "HADOOP_PREFIX" "${HADOOP_PREFIX}"
       verify_env_dir "HADOOP_CONF_DIR" "${HADOOP_CONF_DIR}"
       verify_env_dir "ZOOKEEPER_HOME" "${ZOOKEEPER_HOME}"
       : "${MALLOC_ARENA_MAX:?"variable is not set in accumulo-env.sh"}"
     
    -  # ACCUMULO_XTRAJARS is where all of the commandline -add items go into for reading by accumulo.
    -  # It also holds the JAR run with the jar command and, if possible, any items in the JAR manifest's Class-Path.
    +  CLASSPATH="${lib}/accumulo-start.jar:${conf}:${lib}/slf4j-api.jar:${lib}/slf4j-log4j12.jar:${lib}/log4j.jar:${CLASSPATH}"
    +
       if [[ "$cmd" = "-add" ]]; then
    --- End diff --
    
    I removed the `-add` option in a66cb2888454e9994 and documented how users can set the `CLASSPATH` variable before calling accumulo command.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---