Return-Path: <dev-return-17627-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id EFCC5200C3F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  8 Mar 2017 00:10:14 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id EE5C8160B74; Tue,  7 Mar 2017 23:10:14 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 44D7B160B68
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  8 Mar 2017 00:10:14 +0100 (CET)
Received: (qmail 82837 invoked by uid 500); 7 Mar 2017 23:10:13 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 82814 invoked by uid 99); 7 Mar 2017 23:10:13 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Mar 2017 23:10:13 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 176FBDFD9E; Tue,  7 Mar 2017 23:10:13 +0000 (UTC)
From: phrocker <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-229-accumulo@git.apache.org>
In-Reply-To: <git-pr-229-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #229: ACCUMULO-4597 fixed bug in rfile-info
Content-Type: text/plain
Message-Id: <20170307231013.176FBDFD9E@git1-us-west.apache.org>
Date: Tue,  7 Mar 2017 23:10:13 +0000 (UTC)
archived-at: Tue, 07 Mar 2017 23:10:15 -0000

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/229#discussion_r104804870
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java ---
    @@ -1015,14 +1018,23 @@ public void init(SortedKeyValueIterator<Key,Value> source, Map<String,String> op
     
         }
     
    +    /**
    +     * @return map of locality group names to column families. The default locality group will have {@code null} for a name. RFile will only track up to
    +     *         {@value Writer#MAX_CF_IN_DLG} families for the default locality group. After this it will stop tracking. For the case where the default group has
    +     *         more thn {@value Writer#MAX_CF_IN_DLG} families an empty list of families is returned.
    +     * @see LocalityGroupUtil#seek(Reader, Range, String, Map)
    +     */
         public Map<String,ArrayList<ByteSequence>> getLocalityGroupCF() {
           Map<String,ArrayList<ByteSequence>> cf = new HashMap<>();
     
           for (LocalityGroupMetadata lcg : localityGroups) {
    -        ArrayList<ByteSequence> setCF = new ArrayList<>();
    +        ArrayList<ByteSequence> setCF;
     
    -        for (Entry<ByteSequence,MutableLong> entry : lcg.columnFamilies.entrySet()) {
    -          setCF.add(entry.getKey());
    +        if (lcg.columnFamilies == null) {
    +          Preconditions.checkState(lcg.isDefaultLG, " Group %s has null families. Only expect default locality group to have null families.", lcg.name);
    --- End diff --
    
    haha and it was merged!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---