Return-Path: <dev-return-17533-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 9F3C1200C3B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  3 Mar 2017 19:08:06 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 9B1EB160B5E; Fri,  3 Mar 2017 18:08:06 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 15442160B6D
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  3 Mar 2017 19:08:05 +0100 (CET)
Received: (qmail 46064 invoked by uid 500); 3 Mar 2017 18:08:05 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 46004 invoked by uid 99); 3 Mar 2017 18:08:04 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Mar 2017 18:08:04 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B92F1DFDEF; Fri,  3 Mar 2017 18:08:04 +0000 (UTC)
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-227-accumulo@git.apache.org>
In-Reply-To: <git-pr-227-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #227: ACCUMULO-4596 Stopped using ACCUMULO_HOME for na...
Content-Type: text/plain
Message-Id: <20170303180804.B92F1DFDEF@git1-us-west.apache.org>
Date: Fri,  3 Mar 2017 18:08:04 +0000 (UTC)
archived-at: Fri, 03 Mar 2017 18:08:06 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/227#discussion_r104201693
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/NativeMap.java ---
    @@ -70,11 +70,10 @@
       static {
         // Check standard directories
         List<File> directories = new ArrayList<>(Arrays.asList(new File[] {new File("/usr/lib64"), new File("/usr/lib")}));
    -    // Check in ACCUMULO_HOME location, too
    -    String accumuloHome = System.getenv("ACCUMULO_HOME");
    -    if (accumuloHome != null) {
    -      directories.add(new File(accumuloHome + "/lib/native"));
    -      directories.add(new File(accumuloHome + "/lib/native/map")); // old location, just in case somebody puts it here
    --- End diff --
    
    I think checking for the property, then checking for the ACCUMULO_HOME, then checking doing something in the absence of either of them... at some point, the number of layers makes it hard to grok and is no longer "simple".
    
    If we want simplicity, a better way is to provide good defaults that are easily modified in the configs, rather than trying to handle a bunch of various conditions in code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---