Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-223-accumulo@git.apache.org>
In-Reply-To: <git-pr-223-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #223: ACCUMULO-4409 Create AccumuloMonitorAppender
Content-Type: text/plain
Message-Id: <20170301170158.59DC1DFDE6@git1-us-west.apache.org>
Date: Wed,  1 Mar 2017 17:01:58 +0000 (UTC)
archived-at: Wed, 01 Mar 2017 17:02:00 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/223#discussion_r103735127
  
    --- Diff: assemble/bin/accumulo ---
    @@ -127,13 +127,12 @@ function main() {
         JAVA=($ACCUMULO_JAVA_PREFIX $JAVA)
       fi
       
    -  CLASSPATH="${lib}/accumulo-start.jar:${conf}:${lib}/slf4j-api.jar:${lib}/slf4j-log4j12.jar:${lib}/log4j.jar:${CLASSPATH}"
     
    -  exec "${JAVA[@]}" "-Dapp=$ACCUMULO_CMD" \
    +  CLASSPATH="${conf}:${lib}/*:${CLASSPATH}"
    --- End diff --
    
    The common case would be to have this be non-null, since the rest of the class path will likely be set in the env file. This keeps it simple and readable, and extra colons in the class path don't cause issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---