accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Tue, 28 Mar 2017 20:02:14 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r108522828
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
---
    @@ -89,4 +89,11 @@ public Value getTopValue() {
         return null;
       }
     
    +  @Override
    --- End diff --
    
    > Any ones in particular you had in mind
    
    Negative from me. I just wouldn't be surprised if there were simplifications to be had.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message