accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #159: ACCUMULO-1280: many changes for closing iterator...
Date Tue, 28 Mar 2017 16:03:39 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r108464160
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
    @@ -163,22 +163,22 @@ private static Path createTmpDir(AccumuloConfiguration acuConf,
VolumeManager fs
             try {
               if (reader != null)
                 reader.close();
    -        } catch (IOException e) {
    +        } catch (RuntimeException e) {
               log.error("{}", e.getMessage(), e);
    --- End diff --
    
    Can you update these log messages (the ones in this file that you switched from catching
`IOException` to `RuntimeException`) to have a real error message (e.g. "Caught exception
while closing RFile reader"), please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message