accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...
Date Thu, 23 Mar 2017 16:44:54 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/235#discussion_r107721029
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
---
    @@ -209,13 +209,19 @@ static public long getMemoryInBytes(String str) {
             case 'B':
               multiplier = 0;
               break;
    +        case '%':
    --- End diff --
    
    I would rather not create another `PropertyType`. If the defaults are fixed memory, users
probably won't switch to percentage.  If you are worried about certain properties, I could
add some text to the description of those properties that fixed memory amounts should be used.
 Even if we limit percentage, users can still misconfigure things by setting fixed memory
values that are too high or low for that property.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message