accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...
Date Thu, 23 Mar 2017 16:17:33 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/235#discussion_r107713794
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
---
    @@ -209,13 +209,19 @@ static public long getMemoryInBytes(String str) {
             case 'B':
               multiplier = 0;
               break;
    +        case '%':
    --- End diff --
    
    I'm wondering if it would make more sense to create a new `PropertyType` instead of piggy-backing
on `MEMORY`. Is it confusing to allow percent-values for some of these other properties which
we really never expect users to do?
    
    For example, some properties like `table.file.blocksize` or `tserver.compaction.major.throughput`
make no sense to allow a percentage of total heap.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message