accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...
Date Thu, 23 Mar 2017 14:48:54 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/235#discussion_r107685917
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java ---
    @@ -45,8 +45,8 @@
               + "Examples of invalid durations are '1w', '1h30m', '1s 200ms', 'ms', '', and
'a'.\n"
               + "Unless otherwise stated, the max value for the duration represented in milliseconds
is " + Long.MAX_VALUE),
     
    -  MEMORY("memory", boundedUnits(0, Long.MAX_VALUE, false, "", "B", "K", "M", "G"),
    -      "A positive integer optionally followed by a unit of memory (whitespace disallowed),
as in 2G.\n"
    +  MEMORY("memory", boundedUnits(0, Long.MAX_VALUE, false, "", "B", "K", "M", "G", "%"),
    +      "A positive integer optionally followed by a unit of memory or percentage (whitespace
disallowed), as in 2G.\n"
    --- End diff --
    
    Need to describe behavior of percentage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message