accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...
Date Thu, 23 Mar 2017 14:48:54 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/235#discussion_r107686386
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
---
    @@ -209,13 +209,19 @@ static public long getMemoryInBytes(String str) {
             case 'B':
               multiplier = 0;
               break;
    +        case '%':
    +          int percent = Integer.parseInt(str.substring(0, str.length() - 1));
    +          if (percent <= 0 || percent >= 100) {
    +           throw new IllegalArgumentException("The value of '" + str + "' is not a valid
memory percentage setting.");
    +          }
    +          return Runtime.getRuntime().maxMemory() * percent / 100;
             default:
               return Long.parseLong(str);
           }
           return Long.parseLong(str.substring(0, str.length() - 1)) << multiplier;
         } catch (Exception ex) {
           throw new IllegalArgumentException("The value '" + str + "' is not a valid memory
setting. A valid value would a number "
    -          + "possibily followed by an optional 'G', 'M', 'K', or 'B'.");
    +          + "possibly followed by an optional 'G', 'M', 'K', or 'B'.");
    --- End diff --
    
    Since this is catching exception, it possible that something could go wrong parsing a
`%`.  So error message should include `%` as valid suffix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message