accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #234: ACCUMULO-4583 and ACCUMULO-4610
Date Wed, 22 Mar 2017 17:59:27 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/234#discussion_r107486999
  
    --- Diff: test/src/test/java/org/apache/accumulo/test/proxy/SimpleProxyBase.java ---
    @@ -1362,6 +1364,82 @@ public void userPermissions() throws Exception {
       }
     
       @Test
    +  public void testNamespaceOps() throws Exception {
    +    String testNamespace = "testnamespace";
    +    String testNamespace2 = "testnamespace2";
    +    assertEquals("", client.defaultNamespace(creds));
    +    assertEquals("accumulo", client.systemNamespace(creds));
    +    client.createNamespace(creds, testNamespace);
    +    assertTrue(client.namespaceExists(creds, testNamespace));
    +    assertTrue(client.listNamespaces(creds).contains(testNamespace));
    --- End diff --
    
    Would be good to also check the size of the returned list.  This will make the test catch
unexpected junk in the returned list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message