accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #224: ACCUMULO-4500 ACCUMULO-96 Added summarization
Date Sun, 19 Mar 2017 16:47:01 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/224#discussion_r106811796
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/summary/Summary.java ---
    @@ -78,27 +80,38 @@ public long getLarge() {
         }
     
         /**
    +     * @return The number of files that were deleted after the summary retrieval operations
started. This is a rare race condition where a compaction causes a
    +     *         file to be deleted while retrieving summaries. When this happens, the
file that replaced the deleted file can not be used because it may contain
    +     *         duplication summary information for other files. Avoiding this race condition
would be expensive, so reporting it was chosen. If this condition
    +     *         must be avoided, then compactions must be stopped. Compactions could be
stopped on a cloned table to avoid this.
    +     */
    +    public long getDeleted() {
    +      return deleted;
    --- End diff --
    
    Is this onerous to compute? If this is rare and there is a workaround, I could see keeping
this from public API. If it's not bad to compute/track, it's not an issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message