accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo issue #224: ACCUMULO-4500 ACCUMULO-96 Added summarization
Date Wed, 15 Mar 2017 19:08:05 GMT
Github user keith-turner commented on the issue:

    https://github.com/apache/accumulo/pull/224
  
    > I was a bit brutal in the first review -- we kind of live in a world right now where
our RPC code can just let stuff run for a very long time (you inherited a bit of the problem).
    
    There were so many things to consider for this feature.  I am really glad you made me
focus on this aspect.  
    
    >  we kind of live in a world right now where our RPC code can just let stuff run for
a very long time
    
    The session concept that some of the code currently uses (like scans) defends against
the following : 
    
     * Doing work for a client that is no longer there.
     * Clients starting a second instance of a task, while the first is still processing.
    
    The current code is susceptible to both of the problems above and I would like to avoid
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message