accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #224: ACCUMULO-4500 ACCUMULO-96 Added summarization
Date Mon, 13 Mar 2017 16:25:50 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/224#discussion_r105704840
  
    --- Diff: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java ---
    @@ -1894,4 +1896,71 @@ private String getTableId(String tableName) throws Exception {
         return null;
       }
     
    +  @Test
    +  public void testSummaries() throws Exception {
    +    ts.exec("createtable summary");
    +    ts.exec("config -t summary -s table.summarizer.del=" + DeletesSummarizer.class.getName());
    +    ts.exec("config -t summary -s table.summarizer.fam=" + FamilySummarizer.class.getName());
    +    // ts.exec("config -t summary -s table.summarizer.fam.opt."+CountingSummarizer.INGNORE_DELETES_OPT+"=false");
    +    ts.exec("addsplits -t summary r1 r2");
    +    ts.exec("insert r1 f1 q1 v1");
    +    ts.exec("insert r2 f2 q1 v3");
    +    ts.exec("insert r2 f2 q2 v4");
    +    ts.exec("insert r3 f3 q1 v5");
    +    ts.exec("insert r3 f3 q2 v6");
    +    ts.exec("insert r3 f3 q3 v7");
    +    ts.exec("flush -t summary -w");
    +
    +    String output = ts.exec("summaries");
    +    Assert.assertTrue(output.matches("(?sm).*^.*deletes\\s+=\\s+0.*$.*"));
    --- End diff --
    
    In 7a9fa75 I created a new utility method called `assertMatches` that prints the regex
and output on failure.  A nice improvement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message