accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #231: ACCUMULO-4596 Remove env variable from general.d...
Date Thu, 09 Mar 2017 01:02:18 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/231#discussion_r105064220
  
    --- Diff: assemble/conf/templates/accumulo-env.sh ---
    @@ -48,7 +48,8 @@ JAVA_OPTS=("${ACCUMULO_JAVA_OPTS[@]}"
       '-XX:OnOutOfMemoryError=kill -9 %p'
       '-XX:-OmitStackTraceInFastThrow'
       '-Djava.net.preferIPv4Stack=true'
    -  "-Daccumulo.native.lib.path=${lib}/native")
    +  "-Daccumulo.native.lib.path=${lib}/native"
    +  "-Daccumulo.dynamic.classpaths=${lib}/ext/[^.].*.jar")
    --- End diff --
    
    Do we even need this property? Shouldn't the default value simply be blank in the site
file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message