accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...
Date Wed, 08 Mar 2017 22:23:07 GMT
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/228
  
    >  I also added two properties to standalone cluster testing, accumulo.it.cluster.standalone.client.env
& accumulo.it.cluster.standalone.server.env, that will allow users to optionally add environment
variables (in your case ACCUMULO_CONF_DIR for client and server commands.
    
    These seems duplicative to me, analogs to accumulo.it.cluster.standalone.client.conf and
accumulo.it.cluster.standalone.server.conf.
    
    How are you envisioning those new values to be used? It seems to me that, when the a.i.c.s.client.conf
and a.i.c.s.server.conf are provided, they could set those two new env variables you provided
to be `ACCUMULO_CONF_DIR=<value>` for each. I _think_ that would help push things to
where you want them to go.
    
    So, if the properties provided were..
    
    ```
    accumulo.it.cluster.standalone.client.conf=/etc/accumulo-client
    accumulo.it.cluster.standalone.server.conf=/etc/accumulo-server
    ```
    
    These would be interpreted/converted automatically `StandaloneClusterControl` to be...
    
    ```
    accumulo.it.cluster.standalone.client.env="ACCUMULO_CONF_DIR=/etc/accumulo-client"
    accumulo.it.cluster.standalone.server.env="ACCUMULO_CONF_DIR=/etc/accumulo-server"
    ```
    
    Then, we can "deprecate" the existing properties and replace them with the new env variables.
Have I interpreted this correctly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message