accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #228: ACCUMULO-4596 Improvements to standalone cluster...
Date Wed, 08 Mar 2017 19:17:35 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/228#discussion_r104998805
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java
---
    @@ -149,9 +141,8 @@ String getJarFromClass(Class<?> clz) {
     
       @Override
       public void adminStopAll() throws IOException {
    -    File confDir = getConfDir();
    -    String master = getHosts(new File(confDir, "masters")).get(0);
    -    String[] cmd = new String[] {SUDO_CMD, "-u", user, ACCUMULO_CONF_DIR + serverAccumuloConfDir,
accumuloPath, Admin.class.getName(), "stopAll"};
    +    String master = getHosts(MASTER_HOSTS_FILE).get(0);
    +    String[] cmd = new String[] {SUDO_CMD, "-u", user, accumuloPath, Admin.class.getName(),
"stopAll"};
    --- End diff --
    
    > We should be getting away from using ACCUMULO_CONF_DIR as it setting these env variables
is very prone to errors.
    
    That's fine if you want to move away from them, but I don't see a solution presented as
to how you don't break existing functionality :). As long as we have to keep the tracer user's
password and instance.secret in accumulo-site.xml, we're stuck having a copy of those files
which are not globally readable.
    
    Pushing harder on use of the client.conf is one possibility but this is in a half-cocked
state, IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message