accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #227: ACCUMULO-4596 Stopped using ACCUMULO_HOME for na...
Date Fri, 03 Mar 2017 22:15:10 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/227#discussion_r104250869
  
    --- Diff: assemble/bin/accumulo-util ---
    @@ -411,12 +411,16 @@ function create_config() {
     }
     
     function build_native() {
    -  native_tarball="$basedir/lib/accumulo-native.tar.gz"
       final_native_target="$basedir/lib/native"
    +  if ls $final_native_target/libaccumulo* &> /dev/null; then
    +    echo "Accumulo native library already exists in $final_native_target"
    +    exit 0
    +  fi
     
    +  native_tarball="$basedir/lib/accumulo-native.tar.gz"
       if [[ ! -f $native_tarball ]]; then
    -      echo "Could not find native code artifact: ${native_tarball}";
    -      exit 1
    +    echo "Could not find native code artifact: ${native_tarball}";
    --- End diff --
    
    Suggest `1>&2` on the end of the echo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message