accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #227: ACCUMULO-4596 Stopped using ACCUMULO_HOME for na...
Date Fri, 03 Mar 2017 22:15:10 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/227#discussion_r104253232
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/NativeMap.java ---
    @@ -151,16 +156,13 @@ public static boolean isLoaded() {
       private static boolean loadNativeLib(File libFile) {
         log.debug("Trying to load native map library " + libFile);
         if (libFile.exists() && libFile.isFile()) {
    -      String errMsg = "Tried and failed to load native map library " + libFile;
           try {
             System.load(libFile.getAbsolutePath());
             loadedNativeLibraries.set(true);
             log.info("Loaded native map shared library " + libFile);
             return true;
    -      } catch (Exception e) {
    -        log.error(errMsg, e);
    -      } catch (UnsatisfiedLinkError e) {
    -        log.error(errMsg, e);
    +      } catch (Exception | UnsatisfiedLinkError e) {
    +        log.error("Tried and failed to load native map library " + libFile, e);
    --- End diff --
    
    Should use slf4j substitution syntax instead of string concat.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message